GitLab

Bring EasyUnlockServiceRegular above the 85% test coverage expectation.

This CL also removes unnecessary methods which remained in
EasyUnlockServiceRegular, correctly clears stored remote devices in
prefs when Smart Lock is no longer enabled, and includes minor
refactors necessary to make tests pass.

Coverage before this CL:
  easy_unlock_service.cc:         14.72% (91/618)
  easy_unlock_service_regular.cc: 22.58% (98/434)

Coverage as of this CL:
  easy_unlock_service.cc:         35.76% (221/618)
  easy_unlock_service_regular.cc: 91.96% (389/423)

Report created with:
$ python tools/code_coverage/coverage.py unit_tests \
    -b out/coverage \
    -o out/report \
    -c 'out/coverage/unit_tests --gtest_filter=*EasyUnlockService*' \
    -f chrome/browser/chromeos/login/easy_unlock/

Bug: 949209
Change-Id: I037776f197373ff94099d2f5fc38726d60165cc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788552
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695843}