• Matt Menke's avatar
    Remove use of URLFetcher in HttpServer tests. · 983f2c4e
    Matt Menke authored
    We have two implementations of HttpServer - one wraps a net::Socket and
    one wraps a network::mojom::*Socket. They have near identical tests.
    They have each have one corresponding test that, for some reason, was
    using a URLFetcher. This CL makes both tests use the infrastructure all
    other HttpServer tests use instead, for both tests.
    
    Also worth noting that the net::Socket version is used only by
    chromedriver and DevTools.  The latter seems like it might be a bug,
    and the latter could perhaps be switched to the EmbeddedTestServer,
    which would allow us to remove the net version.
    
    Bug: 1010491
    Change-Id: Ibb17e3795237cfc9005b409ca3fcec32fedb5448
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842015Reviewed-by: default avatarEric Roman <eroman@chromium.org>
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#703042}
    983f2c4e
http_server_unittest.cc 23.4 KB