-
Christopher Cameron authored
Instrument GLES2DecoderImpl::DoCommandsImpl to - record in a crash key all of the GL commands that have been flushed - flush at the end of every time that it is called This will severely regress performance. What we hope to learn: - There's a good chance this will make the bug vanish (egregious glFlush calls have been known to do this), in which case we'll learn nothing. - But maybe we can add less egregious glFlush calls to avoid the issue in Chrome 69 - If elevated crash rates persist, hopefully this will point to a particular call or sequence of calls that is causing the crash Bug: 863817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I462fab8a6d86ee3896dcd9c0c3c4aa68f9de0a69 Reviewed-on: https://chromium-review.googlesource.com/1159831 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580213}
989f7a70