• Sahir Vellani's avatar
    Reland "FlingBoost with experimental fling animation curve" · 98e342dd
    Sahir Vellani authored
    This is a reland of 8e795d5b
    
    The previous CL was reverted because
    FlingControllerWithPhysicsBasedFlingTest in fling_controller_unittest.cc
    was flaky. It was found that occasionally a GestureScrollEnd would be
    incorrectly processed when a GestureScrollUpdate was expected. This CL
    addresses the issue by adding a check for a GSE in relevant areas of the
    test.
    
    
    Original change's description:
    > FlingBoost with experimental fling animation curve
    >
    > Currently, if physics based fling curve is enabled, even if the fling is
    > boosted, the scroll distance is capped by upper bound which is three
    > times the size of viewport. Thus it nullify the effect of fling boosting
    > and travels the same distance as it would if fling is not boosted.
    >
    > This CL fixes fling boosting with physics based fling curve. It does
    > so by increasing the upper bound every time a fling is boosted.
    >
    > Bug: 647137
    > Change-Id: Ib2dd51b37df91168ae1f1e8d33888e3b5dc43e23
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118218
    > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    > Reviewed-by: David Bokan <bokan@chromium.org>
    > Reviewed-by: Daniel Libby <dlibby@microsoft.com>
    > Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#758878}
    
    Bug: 647137
    Change-Id: Ief4dfc3068018ce5fecf168b7c191db5544b90d8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151054
    Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
    Reviewed-by: default avatarDaniel Libby <dlibby@microsoft.com>
    Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
    Reviewed-by: default avatarNavid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#761043}
    98e342dd
physics_based_fling_curve.h 2.82 KB