• Simon Zünd's avatar
    Reland "Keep DevTools navigator.language in-sync with chromiums app language" · 992c5c44
    Simon Zünd authored
    This is a reland of 73ac7d88
    
    The reland changes the test locale from 'es-ES' to 'es'. 'es-ES' is
    unavailable on Mac, while 'es' works (confirmed crash and fix locally).
    
    Original change's description:
    > Keep DevTools navigator.language in-sync with chromiums app language
    >
    > DevTools is considered part of the Chromium UI, so it should be
    > displayed in the same language as the Chromium UI and not the configured
    > accepted language (chrome://settings/languages).
    >
    > This CL moves the code where we override the DevTools renderer
    > preferences around so it works consistently across platforms. It also
    > installs an event handler in case the user changes his language settings
    > so `navigator.language` has consistently the same value in the
    > DevTools renderer.
    >
    > R=petermarshall@chromium.org
    >
    > Bug: chromium:1125490
    > Change-Id: Iaac568d82357d6ae7c50d5022d687f4f1741b147
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398538
    > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#805219}
    
    Bug: chromium:1125490, chromium:1126379
    Change-Id: I3b24b73ecb19d8290393a8ebf72db424bc098eee
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401464Reviewed-by: default avatarPeter Marshall <petermarshall@chromium.org>
    Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#805704}
    992c5c44
devtools_window.cc 59.2 KB