GitLab

As per the linked bug, non-null anchor views will become mandatory in
LocationBarBubbleDelegateView. This change modifies IntentPickerBubbleView to
always pass a non-null anchor view. In fact, it already always passed a non-null
anchor view in actual use, since it is only ever invoked in one place
conditional on the anchor view being non-null. As a consequence, this change
deletes the null anchor view path in IntentPickerBubbleView, which removes some
bespoke layout constants (yay!)

This change also refactors IntentPickerBubbleView a bit: IntentPickerBubbleView
itself is built on all Views platforms, but its tests were only built on
ChromeOS. This change therefore makes the tests build on all platforms alongside
the code. As of right now, I think this code is only invoked on ChromeOS, but in
a runtime way that makes it difficult to be sure.

This change also makes private a couple of test-only methods on
IntentPickerBubbleView that used to be public.

Bug: 989080
Change-Id: Id1a9d28ffb5c11e164547ce5c5aac5b26c0ef6d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726431
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682830}