• Xianzhu Wang's avatar
    Reland "Mark some blink testing targets testonly" · 99943a99
    Xianzhu Wang authored
    This reverts commit 1a394948.
    
    Reason for revert: crbug.com/1011605 (probably caused by a linker bug
    on ARM ChromeOS) has been worked around in crbug.com/1011161.
    
    Original change's description:
    > Revert "Mark some blink testing targets testonly"
    >
    > This reverts commit a4453534.
    >
    > Reason for revert: http://crbug.com/1011605
    >
    > Original change's description:
    > > Mark some blink testing targets testonly
    > >
    > > This forbids production code depending on these targets, and enables
    > > these targets to depend on other testonly targets in the future.
    > >
    > > The only dependency prevented core:testing from being testonly was
    > > from BlinkLeakDetector. Add Page::PrepareForLeakDetection() and
    > > InternalSettingsPageSupplementStub (in page.h) to avoid the
    > > dependency.
    > >
    > > Change-Id: Ie22676a233d9b5c02cf3cde79629f4b84782b572
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829586
    > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#701334}
    >
    > TBR=wangxianzhu@chromium.org,chrishtr@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Change-Id: Icb266b74d3f75ffff2176ec2b0ca4871d99e7587
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842973
    > Reviewed-by: Kuo Jen Wei <inker@chromium.org>
    > Commit-Queue: Kuo Jen Wei <inker@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#703202}
    
    TBR=wangxianzhu@chromium.org,chrishtr@chromium.org,inker@chromium.org
    
    Change-Id: I7390267d2f56aed847dd0f615bebdac5e2348526
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876870Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#708770}
    99943a99
BUILD.gn 4.75 KB