• Wez's avatar
    Revert "[Fuchsia] Remove system logging logic from RunPackage()" · 99f8551b
    Wez authored
    This reverts commit d6fe2c47.
    
    Reason for revert: This causes us to lose backtraces from crashes under
    the runner scripts. Although the output can be re-enabled via the
    --system-log-file option, that bypasses symbolization so is also not
    useful.
    
    Original change's description:
    > [Fuchsia] Remove system logging logic from RunPackage()
    > 
    > Previously runner scripts implemented system logs collection in two
    > enabled by default, but could be turned off with --exclude-system-logs.
    > (2) was disabled by default, but can be turned on with
    > --system-log-file. (2) is enabled on the bots now. This CL removes (1)
    > in order to remove noice from runner script output and to simplify code.
    > When necessary --system-log-file=- flag can be used to get the previous
    > behavior.
    > 
    > places: (1) in RunPackage, and (2) in Target implementations. (1) was
    > Change-Id: I787ff4d8ac54f5c0cd13d0e9d8a71aad05cdd45c
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674668
    > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    > Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
    > Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#672180}
    
    TBR=kmarshall@chromium.org,sergeyu@chromium.org
    Bug: 984993
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: Ib84af3efcb5c5859938328977a2aecb4a5428422
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707051Reviewed-by: default avatarWez <wez@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#678524}
    99f8551b
common_args.py 5.91 KB