-
Jinho Bang authored
Before this patch, when calling updateWith() w/o shippingOptions in PaymentRequestUpdateEvent, it will be set to empty array by force. This is a implementation bug and doesn't match behavior with the spec[1]. It cause that calling updateWith() with no shippingOptions resets the shipping address on payment sheet UI. To resolve the problem, this patch makes the shippingOptions member optional. FYI, we already fixed it for payerdetailchange and paymentmethodchange events[2]. Use count data: https://www.chromestatus.com/metrics/feature/timeline/popularity/2622 https://www.chromestatus.com/metrics/feature/timeline/popularity/2623 [1] https://w3c.github.io/payment-request/#update-a-paymentrequest-s-details-algorithm [2] https://chromium-review.googlesource.com/c/chromium/src/+/1280563 Bug: 902291 Change-Id: If7b2ba6890ac4905ad1acf79c034fe866ec3beb4 Reviewed-on: https://chromium-review.googlesource.com/c/1438980Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#628570}
9a33b591