• Zentaro Kavanagh's avatar
    Fix bug in MD4 implementation that creates incorrect hash. · 4e3aae84
    Zentaro Kavanagh authored
    - Inputs with length % 64 >= 56 potentially generate the wrong hash.
    - In MD4Sum function the last 4 bytes of the final array were never
      initialized.
    - This would result in NTLM failing due to incorrect hash when the
      password length % 32 >= 28 (unicode password).
    - Fixes fuzzer bug that was caught by new NTLM fuzzer.
    - Added test suite from RFC 1320 for MD4.
    - Md4Test.RfcTest6_Mod56CornerCase fails without this fix.
    
    BUG=chromium:752491
    
    Change-Id: If7b718b8c80f00819200332a027bb2f430b8f68e
    Reviewed-on: https://chromium-review.googlesource.com/602693
    Commit-Queue: Zentaro Kavanagh <zentaro@google.com>
    Reviewed-by: default avatarAsanka Herath <asanka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#492432}
    4e3aae84
md4.h 2.89 KB