• Thomas Anderson's avatar
    Revert "Add bool constructor with type for PolicyValue" · 9c2422bd
    Thomas Anderson authored
    This reverts commit 30d9990c.
    
    Reason for revert: Suspected cause of build failure on ilder Deterministic Linux (dbg) Build 18293:
    https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/18293?blamelist=1#blamelist-tab
    
     Checking libblink_common.so difference: (10672 deps)
       obj/third_party/blink/common/common/document_policy_features.o
    
    Original change's description:
    > Add bool constructor with type for PolicyValue
    > 
    > Previously, boolean PolicyValue is missing a constructor with type
    > specification on PolicyValue class. It caused some inconvenience
    > on code generation and testing. With the introduction of enum
    > PolicyValue, this becomes more obvious because enum type's constructor
    > also comes with a type parameter.
    > 
    > In order to simplify the codegen and testing logic, this CL adds a dummy
    > constructor for boolean type PolicyValue.
    > 
    > Note: the constructor with type parameter aims to distinguish policy
    > values that have same C++ type representation but different policy value
    > type, e.g. IncDouble and DecDouble, Enum and Int.
    > 
    > Change-Id: I11ba793c73a770d7211e21c6a94d29f5557ac284
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347365
    > Commit-Queue: Charlie Hu <chenleihu@google.com>
    > Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    > Reviewed-by: Ian Clelland <iclelland@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#798714}
    
    TBR=iclelland@chromium.org,foolip@chromium.org,chenleihu@google.com
    
    Change-Id: I79f53710b14f22a7c81b4c757cbee03160c6addb
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360796Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#798853}
    9c2422bd
policy_value.cc 3.55 KB