GitLab

Instead, use SetExtraView. The create method is renamed to avoid conflict with
the deprecated parent method it used to override, but left as a method on the
clsas because it sets up some of the class's internal state.

The tests for this class were calling CreateExtraView manually, which is
not allowed by the contract of DialogDelegate::CreateExtraView, but
happened to work on this class. This change therefore introduces an
accessor DialogDelegate::GetExtraView() that pulls the extra view out of
the DialogClientView and uses that in these tests to access the existing
extra view.

Bug: 1011446
Change-Id: I8ad2f3d20d94b461d78b02f3b2a671b2a15a6a31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876789
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709503}