• Peter Boström's avatar
    Unify ink-drop style to flood fill with masks. · 9c8b10b5
    Peter Boström authored
    This change makes flood fill the default ink-drop style. Square InkDrops
    are currently bugs in the browser that are kind-of hidden by InkDrop
    masks.
    
    It makes use of the same path that FocusRing uses for masks to make sure
    that the InkDrop and FocusRing are in sync by default. These mismatch
    bugs keep popping up, especially on Mac, as testers verify new parts of
    the UI.
    
    Follow-up changes will be to reduce the number of classes that override
    CreateInkDrop methods and make sure that they explicitly request a
    SquareInkDrop when they want it.
    
    Bug: chromium:888204, chromium:907833, chromium:915284
    
    Change-Id: I681b93d6f5bdfe7f78421ebc8f2fbd522fb6eee4
    Reviewed-on: https://chromium-review.googlesource.com/c/1367186
    Commit-Queue: Peter Boström <pbos@chromium.org>
    Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
    Reviewed-by: default avatarMohsen Izadi <mohsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#619533}
    9c8b10b5
toolbar_action_view.cc 11.9 KB