• Caleb Rouleau's avatar
    Reland "Fixed first_run test failure because of the global variables" · 9ce7f03f
    Caleb Rouleau authored
    This reverts commit 242fe9d5.
    
    Reason for revert: The bot is working again before the revert when in: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/30249
    
    Original change's description:
    > Revert "Fixed first_run test failure because of the global variables"
    > 
    > This reverts commit 8d01fd2f.
    > 
    > Reason for revert: crbug.com/822316 looks like it broke net_unittests?
    > 
    > bug: 822316
    > 
    > Original change's description:
    > > Fixed first_run test failure because of the global variables
    > > 
    > > Fixed typical problem with unit tests and global variables.
    > > If unit test modifies global variables then it can affect other tests
    > > which are runned in the same process. Added reseting of the global
    > > variables to avoid this.
    > > 
    > > Change-Id: I2045700473ac074209f4d48a6cedbd3dad24ccd5
    > > Reviewed-on: https://chromium-review.googlesource.com/952905
    > > Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
    > > Reviewed-by: Carlos Pizano <cpu@chromium.org>
    > > Reviewed-by: Gabriel Charette <gab@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#543345}
    > 
    > TBR=gab@chromium.org,cpu@chromium.org,a-v-y@yandex-team.ru,vitreb@yandex-team.ru
    > 
    > Change-Id: I616e5415b0e786dc5bd3075f1360b31a6452e256
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Reviewed-on: https://chromium-review.googlesource.com/964621
    > Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    > Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#543423}
    
    TBR=gab@chromium.org,cpu@chromium.org,crouleau@chromium.org,a-v-y@yandex-team.ru,vitreb@yandex-team.ru
    
    Change-Id: I3e37c027b65d1df944d3246dd6c8314d9dc9a7ee
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/963853Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
    Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#543430}
    9ce7f03f
first_run_unittest.cc 5.98 KB