GitLab

PlayerIdentifier::operator<() was defined through operator<() on
PlayerIdentifier hashes.  This almost always gives correct results, but
not in general.  Hash collisions are possible (collisions of sums of
hashes are a bit "more possible", see old PlayerIdentifier::Hash()), so
operator<() could return false for two PlayerIdentifier instances that
are actually in a less-than relationship.

The hash function is not really needed anyway, because base::flat_set is
better suited here than std::unordered_set.

Change-Id: I12eec1aa27774d0bd6e10232c35968832fed1ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492440Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Cr-Commit-Position: refs/heads/master@{#823641}