• Hans Wennborg's avatar
    Revert "Unify CPU features detection code" · 9d8f9764
    Hans Wennborg authored
    This reverts commit 6f7e5e79.
    
    Reason for revert: This broke the build, e.g.
    https://ci.chromium.org/p/chromium/builders/ci/ios-device/144512
    
    ../../third_party/zlib/cpu_features.c:75:13: error: unused function '_cpu_check_features' [-Werror,-Wunused-function]
    static void _cpu_check_features(void)
                ^
    
    Original change's description:
    > Unify CPU features detection code
    > 
    > This will allow to remove some duplicated code (i.e. thread synchronization)
    > while at same time removing unnecessary use of inline ASM for Intel features
    > detection.
    > 
    > A few other advantages:
    >  - remove some extra logic (e.g. no need to test the platform to include the
    >    correct CPU detection header).
    >  - simplifies the buildsystem (i.e. we always include cpu_features.c)
    >  - get rid of the simd_stub file.
    > 
    > Bug: 1032721
    > Change-Id: Ic93472d3337bc2cbe092d4cf8fbe4b31b1ceca6d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976820
    > Reviewed-by: Chris Blume <cblume@chromium.org>
    > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
    > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#727038}
    
    TBR=cavalcantii@chromium.org,cblume@chromium.org,mtklein@chromium.org,adenilson.cavalcanti@arm.com
    
    Change-Id: I20c5dedb98ba8b5d304ff1339042bcf243505e88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1032721
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979790Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
    Commit-Queue: Hans Wennborg <hans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#727039}
    9d8f9764
arm_features.c 3.4 KB