• Colin Blundell's avatar
    [SSLErrorHandler] Move check of overrides allowed pref to embedder · 9ee731dd
    Colin Blundell authored
    SSLErrorHandler currently checks internally whether the ability for the
    user to proceed past an SSL interstitial has been disabled via prefs.
    This pref is a //chrome-level one that WebLayer will never modify from
    the default behavior of allowing such proceeding. Thus, rather than
    componentize the pref, this CL instead passes the value of whether the
    user is allowed to proceed past SSL interstitials to
    SSLErrorHandler::HandleSSLError(), giving the boolean a default value
    of true so that embedders other than //chrome don't need to worry about
    what the default behavior should be.
    
    To avoid needing to thread this argument through
    SSLErrorNavigationThrottle, this CL also introduces a //chrome-level
    wrapper of SSLErrorHandler::HandleSSLError() that supplies
    //chrome-level parameters. This wrapper will be useful for a few other
    params, and we will change the current passing of NetworkTimeTracker to
    occur this way as well rather than being threaded through
    SSLErrorNavigationThrottle.
    
    Bug: 1030692
    Change-Id: I840e97b41759e7982b6a0975570a82a9b52ed5ff
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014504
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: default avatarCarlos IL <carlosil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#734401}
    9ee731dd
ssl_error_handler.cc 36.9 KB