• Ryan Hansberry's avatar
    [Nearby] Suppress 'discoverable' Bluetooth notification during sharing. · 9f0ff082
    Ryan Hansberry authored
    If Nearby Share is actively broadcasting itself as able to receive
    content (by making the device discoverable over Bluetooth), do not
    display the "Your device is discoverable..." notification.
    
    This change requires the addition of a new method,
    NearbyShareDelegateImpl::IsEnableHighVisibilityRequestActive().
    Using the existing method
    NearbyShareDelegateImpl::IsHighVisibilityOn() is not sufficient
    because BluetoothNotificationController::AdapterDiscoverableChanged()
    is triggered before NearbyShareDelegateImpl::IsHighVisibilityOn()
    becomes true.
    
    Making generic Bluetooth UI logic (BluetoothNotificationController)
    aware of the inner workings of Nearby is not ideal, but is the
    quickest solution we have available before launch. We will clean
    up this behavior leak in crbug.com/1155669.
    
    Bug: 1155668
    Change-Id: I3174d9e1af777b97ef6e5daed9a80f75831ca41f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566407
    Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
    Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
    Reviewed-by: default avatarJames Vecore <vecore@google.com>
    Cr-Commit-Position: refs/heads/master@{#833897}
    9f0ff082
test_nearby_share_delegate.cc 1.13 KB