• Dana Fried's avatar
    Fix accessibility of TabbedPane · 9f1c196b
    Dana Fried authored
    Previous to this change, neither the tabbed pane itself nor its contents
    pane would report a meaningful accessible name/title. When using
    accessible keyboard navigation (tab, arrows) to navigate a dialog that
    had a tabbed pane (such as the site cookies dialog), when entering the
    tabbed pane a screen reader user would simply hear "tabbed pane", and
    when using the arrow keys to select the tab, the user would hear the
    (unspecified) accessible title of the pane view inside the tab, which
    was usually just "pane" or nothing at all.
    
    This CL makes the following changes:
     - the title of the entire TabbedPane now reflects the currently active
       tab title
     - by default, the contents pane of each tab is assigned the same
       accessible name/title and role as the tab (it can be overridden later
       if necessary)
    
    Now, for example, when using NVDA, when the user first enters the
    cookies dialog, they hear: "allowed tab control". When navigating
    between tabs using the arrow keys, they will continue to hear "allowed
    tab" and "blocked tab" as they switch back and forth.
    
    Bug: 962966
    Change-Id: I805281bf5429e03ca77f98e167041a5df3cbee8c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717228Reviewed-by: default avatarAllen Bauer <kylixrd@chromium.org>
    Commit-Queue: Dana Fried <dfried@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#680630}
    9f1c196b
tabbed_pane_unittest.cc 10.8 KB