• Hoch Hochkeppel's avatar
    Postpone MaxSharedFileBytes check · 9f90c933
    Hoch Hochkeppel authored
    Removing the check of the size of the shared files from
    share_service_impl, but leaving the unit tests prepped to cover these
    cases to validate that the platform-specific implementations check this
    when they are processing the shared files.
    
    The scenario being fixed with this change is sharing native files,
    easily exercised with the Web Share Test page:
    https://w3c.github.io/web-share/demos/share-files.html
    
    When these files are initially created as blobs they are marked as being
    of unknown size, and though the navigator_share code does check their
    size as part of the Share operation, this check does not modify the
    actual blob, so when it is serialized the recorded size will be the max
    uint64 value. Matching the Android implementation, this postpones the
    file size check till the files are actually being processed (in the
    platform-specific implementations).
    
    Bug: 1035527
    Change-Id: I59ea9bfadb06205ae155f31947fa04093f06503d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415431Reviewed-by: default avatarEric Willigers <ericwilligers@chromium.org>
    Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#807765}
    9f90c933
share_service_impl.cc 5.1 KB