• Nick Burris's avatar
    [SecurePaymentConfirmation] Add header view · 9fc875c6
    Nick Burris authored
    Add the header icon and progress bar to the secure payment confirmation
    dialog. Before this patch, the header icon was a property of the model.
    Since the model lives in //components, but the icon comes from //chrome,
    it's awkward for the controller to get the icon from the view just to
    pass a pointer to the model for the view to dereference later. See patch
    set 3 for what this looks like. Since the icon is specific to the
    SecurePaymentConfirmationDialogView implementation anyway, this patch
    removes the icon from the model and keeps the logic local to the view.
    
    Bug: 1110322
    Change-Id: I8681bc00c4d48d1b98f3c939f920b5ea44f0ff02
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358821
    Commit-Queue: Nick Burris <nburris@chromium.org>
    Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#799873}
    9fc875c6
secure_payment_confirmation_model_unittest.cc 2.98 KB