-
Thiemo Nagel authored
This reverts commit 926cd1f5. Reason for revert: Flakiness in BackGestureBrowserTest.PreventDefault Three failures observed on linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel https://chromium-swarm.appspot.com/task?id=4c8d35366f7d4710#BackGestureBrowserTest.PreventDefault,BackGestureBrowserTest.TouchActions,DemoSetupArcSupportedTest.ShowOfflineSetupOptionOnNetworkList,NetworkQualityTrackerBrowserTest.SimulateNetworkServiceCrash,SwitchAccessPredicateTest.LeafPredicate,TopControlsSlideControllerTest.DisplayRotation ../../chrome/browser/ui/ash/back_gesture_browsertest.cc:210: Failure Value of: recorder.HasReceivedEvent(ui::EventType::ET_KEY_PRESSED) Actual: true Expected: false Stack trace: #0 0x5585e4320fef BackGestureBrowserTest_PreventDefault_Test::RunTestOnMainThread() #1 0x5585e7da383d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #2 0x5585e7900459 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #3 0x5585e78ff599 ChromeBrowserMainParts::PreMainMessageLoopRun() #4 0x5585e4a12dd9 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #5 0x5585e5c7fd84 content::BrowserMainLoop::PreMainMessageLoopRun() #6 0x5585e6079033 content::StartupTaskRunner::RunAllTasksNow() #7 0x5585e5c7ed8a content::BrowserMainLoop::CreateStartupTasks() #8 0x5585e5c81611 content::BrowserMainRunnerImpl::Initialize() #9 0x5585e5c7d3ad content::BrowserMain() #10 0x5585e7384f2d content::ContentMainRunnerImpl::RunServiceManager() #11 0x5585e73849b7 content::ContentMainRunnerImpl::Run() #12 0x5585e99d13d5 service_manager::Main() #13 0x5585e67835d4 content::ContentMain() #14 0x5585e7da33ba content::BrowserTestBase::SetUp() #15 0x5585e77dca3a InProcessBrowserTest::SetUp() Original change's description: > back gesture: Disable back gesture for {touch-action:none} web pages/apps. > > Bug: 1063144 > Change-Id: I85379cc2f4aded28ac9eefb09e2086d446f42168 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166360 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773852} TBR=sky@chromium.org,xdai@chromium.org,dtapuska@chromium.org,afakhry@chromium.org Change-Id: I5123a071659d23d7731a55d1420442c9b878b8bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225764Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#774078}
9fd6b9a7
