Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
T
tangled
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • eriksson monteiro
  • tangled
  • Repository

Switch branch/tag
  • tangled
  • chromeos
  • components
  • camera_app_ui
  • resources
  • sounds
  • shutter.ogg
Find file HistoryPermalink
  • Wei Lee's avatar
    [CCA] Move things out of src/ and avoid using relative path · a05c1cbe
    Wei Lee authored Sep 29, 2020
    For historical reason, we put our js files, html files and resources
    under src/ directory of CCA directory. However, we reference the
    resource differently on platform app/SWA.
    
    On platform app, a resource
    foo.js is referenced as "chrome-extension://.../js/foo.js".
    While on SWA, it is references as: "chrome://.../src/js/foo.js".
    
    We should align the path between two versions of CCA and further replace
    the relative path by absolute paths in resource files.
    By doing so, we can further support launching CCA (SWA) when typing
    random CCA URL in Chrome. (e.g. chrome://camera-app/foo)
    
    NOPRESUBMIT=true
    
    Bug: 980846
    Test: cca deploy [DUT]
    Test: cca test [DUT]
    Test: Both version (Platform app / SWA) works normally
    Test: tast run [DUT] camera.CCAUI*
    Change-Id: I845fe698ad92ee8da003b2ac3d12519509bdedd4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434188
    Commit-Queue: Wei Lee <wtlee@chromium.org>
    Reviewed-by: default avatarInker Kuo <inker@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#811569}
    a05c1cbe
shutter.ogg 6.68 KB

Download (6.68 KB)

Replace shutter.ogg

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.