GitLab

The crash is caused by the callback UIStringOverrider::OverrideUIString() in
ApplyUIStringOverrides() is called before resource bundle is initialized. In
this CL, we checks whether the resource bundle has been initialized or not. If
not, we cache the UI strings to be override in a map owned by the
VariationsFieldTrialCreator, and override these UI strings once the full browser
starts.

Bug: 893707
Change-Id: Ia23bc46a5e13a20ab784ff48d565ce1438a6aa0b
Reviewed-on: https://chromium-review.googlesource.com/c/1274001
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600564}