• Andrew Grieve's avatar
    Reland "Add -noverify to build commands to improve runtime (local builds only)" · a1325695
    Andrew Grieve authored
    This reverts commit 17e2a917.
    
    Reason for revert: Ensure buildtools.py is a no-op on bots.
    
    Original change's description:
    > Revert "Add -noverify to build commands to improve runtime (local builds only)"
    >
    > This reverts commit 132e1deb.
    >
    > Reason for revert: Android ASAN bot compilation failures: https://ci.chromium.org/p/chromium/builders/ci/Android%20ASAN%20%28dbg%29/26489
    >
    > Original change's description:
    > > Add -noverify to build commands to improve runtime (local builds only)
    > >
    > > The flag is guarded by treat_warnings_as_errors=false so that it
    > > will apply only to local developer builds.
    > >
    > > Results from //tools/android/build_speed/benchmark.py base_java_sig:
    > > With change:
    > > base_java_sig: 68.0s avg (68.8s, 67.2s)
    > > base_java_sig: 68.4s avg (68.6s, 68.2s)
    > >
    > > Without change:
    > > base_java_sig: 69.4s avg (69.3s, 69.5s)
    > > base_java_sig: 69.7s avg (69.7s, 69.7s)
    > >
    > > time out/Debug/bin/run_base_junit_tests:
    > > With Change:
    > > real 0m22.741s
    > > real 0m23.543s
    > >
    > > Without change:
    > > real 0m23.176s
    > > real 0m24.328s
    > >
    > > Bug: 1117222
    > > Change-Id: I4bfd742165468bf9538e6fa0dc8f35daa9e0f23f
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313299
    > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    > > Auto-Submit: Andrew Grieve <agrieve@chromium.org>
    > > Reviewed-by: Peter Wen <wnwen@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#799285}
    >
    > TBR=wnwen@chromium.org,agrieve@chromium.org
    >
    > Change-Id: I82f411e5dab89c361a30c33e9103bd8561f19765
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1117222
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362493
    > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
    > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#799471}
    
    Bug: 1117222
    Change-Id: Ib43bfe72869def7da43b237360df0e155149a963
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363975Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Auto-Submit: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#800233}
    a1325695
dex_jdk_libs.py 2.87 KB