• Melissa Zhang's avatar
    Reland "Change ButtonPressed overrides to callbacks: c/b/ui/views/sharesheet/" · a1b44281
    Melissa Zhang authored
    This reverts commit f524b7f0.
    
    Reason for revert: I will add a simple fix.
    
    Original change's description:
    > Revert "Change ButtonPressed overrides to callbacks: c/b/ui/views/sharesheet/"
    >
    > This reverts commit 1ac9a1da.
    >
    > Reason for revert: Breaking UI
    >
    > Original change's description:
    > > Change ButtonPressed overrides to callbacks: c/b/ui/views/sharesheet/
    > >
    > > This allows converting |targets_| from a member to a parameter that's
    > > passed around.  I also did some other cleanup while there.
    > >
    > > Bug: 772945
    > > Change-Id: Iaa7f70594ba109d1598da3566856e90c8b09629d
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481246
    > > Commit-Queue: Melissa Zhang <melzhang@chromium.org>
    > > Reviewed-by: Melissa Zhang <melzhang@chromium.org>
    > > Auto-Submit: Peter Kasting <pkasting@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#818324}
    >
    > TBR=pkasting@chromium.org,melzhang@chromium.org
    >
    > Change-Id: Ief930a27f44caef219bf782a7534ef8bc76d83ef
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 772945
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483745
    > Reviewed-by: Melissa Zhang <melzhang@chromium.org>
    > Commit-Queue: Melissa Zhang <melzhang@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#818357}
    
    TBR=pkasting@chromium.org,melzhang@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 772945
    Change-Id: I00d7acd3d7c812dfde8b584c2e53b6b2e1c237a7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483987Reviewed-by: default avatarMelissa Zhang <melzhang@chromium.org>
    Commit-Queue: Melissa Zhang <melzhang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#818379}
    a1b44281
sharesheet_bubble_view.cc 16.1 KB