• Ella Ge's avatar
    [LargeSplash:1]InstallableManager fetch splash instead of badge · a1f3f8b2
    Ella Ge authored
    This CL adds splash icon fetching to InstallableManager and removes
    badge icon part.
    
    A bool valid_splash_icon is added to InstallableParams but
    valid_badge_icon is not removed yet since the usages of
    "params.valid_badge_icon" are not removed yet. (going to be remove in
    the following CLs).
    Now InstallableParams class has 9 booleans, so chromium style check
    require it to have a explicit constructor. The constructor (and
    associate .cc file) will be removed once valid_badge_icon is removed.
    
    With this CL, badge icon will not be fetched even if valid_badge_icon is
    set. It's ok to do so since it's not used.
    
    Bug: 1043271
    Change-Id: Ife4e99afe4fa9d94580adfff3b9ba6a6f312254c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037813
    Commit-Queue: Ella Ge <eirage@chromium.org>
    Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
    Reviewed-by: default avatarPeter Kotwicz <pkotwicz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#744013}
    a1f3f8b2
manifest_one_maskable.json 276 Bytes