• agrieve's avatar
    Revert "Enable extracting unwind table on official builds without channel" · a2474b64
    agrieve authored
    This reverts commit eb07cea1.
    
    Reason for revert: Windows tryjobs are failing.
    https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-rel%2F81420%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout for an example.
    
    ERROR at //base/BUILD.gn:1802:33: Undefined identifier in string expansion.
        "CAN_UNWIND_WITH_CFI_TABLE=$can_unwind_with_cfi_table",
                                    ^------------------------
    "can_unwind_with_cfi_table" is not currently in scope.
    See //BUILD.gn:65:5: which caused the file to be included.
        "//base:base_perftests",
        ^----------------------
    GN gen failed: 1
    
    Original change's description:
    > Enable extracting unwind table on official builds without channel
    > 
    > This CL enables extraction of unwind tables for chrome when
    > is_official_build is set to true and when android_channel is not set to
    > a release channel. This affects build time only on official builds.
    > Also, Set legacy heap profiler to use unwinder for profiling.
    > 
    > TBR=dpranke@chromium.org
    > BUG=819888
    > 
    > Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244
    > Reviewed-on: https://chromium-review.googlesource.com/976944
    > Reviewed-by: Siddhartha S <ssid@chromium.org>
    > Reviewed-by: agrieve <agrieve@chromium.org>
    > Commit-Queue: Siddhartha S <ssid@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#546425}
    
    TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org
    
    Change-Id: Id033094871dfcf74248f631390f15f379d9cd3c7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 819888
    Reviewed-on: https://chromium-review.googlesource.com/983893Reviewed-by: default avataragrieve <agrieve@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#546478}
    a2474b64
extract_unwind_tables.gni 1.2 KB