• Greg Thompson's avatar
    Revert "capture mode: window capture change." · a259d6db
    Greg Thompson authored
    This reverts commit 2af0583b.
    
    Reason for revert: consistent CaptureModeTest.WindowCapture failures in ash_unittests (e.g., https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20786)
    
    Original change's description:
    > capture mode: window capture change.
    >
    > In window capture mode, the user should be able to interactively select
    > a window to capture. when the to-be-captured window's bounds or state is
    > changed, we should update the capture region to reflect the change as
    > well.
    >
    > Other changes that is worth mentioning in this CL:
    > - Window stacking order or activation order will not be changed by the
    > capture window selection change
    > - If current selected is closed/minimized or becomes invisible, we
    > automatically select another window under mouse/touch event location.
    > and if there is no such window, do nothing.
    > - If another window is activated when a window is selected, if the
    > activated window is under mouse/touch event location, it will be focused
    > instead.
    > - When a mouse moved over a selectable window, change its cursor to
    > either capture icon or recording icon
    >
    > Bug: 1127526
    > Change-Id: Icfdbed419dadfe0301b60da693f01010f4a2da2c
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421090
    > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    > Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    > Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#812976}
    
    TBR=xdai@chromium.org,afakhry@chromium.org,newcomer@chromium.org
    
    Change-Id: I4f2f3c21ae546ca1442a29d95b58f11f4da3b43f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1127526
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444990Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#813093}
    a259d6db
capture_mode_unittests.cc 19.5 KB