GitLab

This reverts commit d5e51b0e.

Reason for revert: Fix MSan issue

The following on the original CL caused an MSan issue:

`const GURL& url = media_hostnames_.back();
 media_hostnames_.pop_back();`

A reference to the URL is taken and then immediately after the URL is
deleted. The fix removes access to the deleted memory.

Original change's description:
> Revert "network_diagnostics: Add VideoConferencing routine"
>
> This reverts commit 2f0a1300.
>
> Reason for revert: VideoConferencingRoutineTest fails on MSan bot due to use-of-uninitialized-value:
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21568
>
> Original change's description:
> > network_diagnostics: Add VideoConferencing routine
> >
> > Tests for successful UDP and TCP connections to a STUN server and
> > whether several Google media hostnames are reachable.
> >
> > BUG=b/172994051
> > TEST=unit_tests --gtest_filter=VideoConferencingRoutineTest.*
> >
> > Change-Id: I64d2784c3b3ae111c9e924b1296a5463dcb7cea2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535997
> > Commit-Queue: Kartik Hegde <khegde@chromium.org>
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Reviewed-by: Hugo Benichi <hugobenichi@google.com>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#833465}
>
> TBR=stevenjb@chromium.org,dcheng@chromium.org,hugobenichi@google.com,khegde@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I6d4f020371052227ab20ab45c3ffe85bb6f57310
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: b/172994051
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573557
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#833611}

TBR=stevenjb@chromium.org,dcheng@chromium.org,ksakamoto@chromium.org,hugobenichi@google.com,khegde@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because this is a reland.

Bug: b/172994051
Change-Id: Iaf12c4be3e9776188c545b2a792557bb9549edf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575365Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kartik Hegde <khegde@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834057}