• Sunny Sachanandani's avatar
    Reland "gpu: Add message filter destructor stack traces to crash keys." · a2c68af4
    Sunny Sachanandani authored
    This is a reland of 1d629632
    
    I had assumed that unregistered crash keys would be a nop but they need
    to be registered or else a DCHECK is triggered.
    
    I also made sure gpu/config/gpu_crash_keys is used as the source of
    truth for gpu related crash keys.
    
    Original change's description:
    > gpu: Add message filter destructor stack traces to crash keys.
    > 
    > base::debug::Alias values don't show up in minidumps. Using crash keys
    > is recommended for use-after-free bugs in the following doc:
    > http://dev.chromium.org/developers/debugging-with-crash-keys
    > 
    > R=jbauman,rsesek,sandersd
    > BUG=729483
    > 
    > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    > Change-Id: I8fd129daf66dc9235307a28fe5cd7a6c23b85a94
    > Reviewed-on: https://chromium-review.googlesource.com/538056
    > Reviewed-by: Robert Sesek <rsesek@chromium.org>
    > Reviewed-by: John Bauman <jbauman@chromium.org>
    > Reviewed-by: Dan Sanders <sandersd@chromium.org>
    > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#480879}
    
    TBR=jbauman,sandersd
    
    Bug: 729483, 735175
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Change-Id: I05c46bb583135dff05d5bc75dff694a1caa54b32
    Reviewed-on: https://chromium-review.googlesource.com/541937Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
    Reviewed-by: default avatarBo Liu <boliu@chromium.org>
    Reviewed-by: default avatarRobert Shield <robertshield@chromium.org>
    Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
    Reviewed-by: default avatarAlok Priyadarshi <alokp@chromium.org>
    Reviewed-by: default avatarKen Rockot <rockot@chromium.org>
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#481787}
    a2c68af4
crash_keys.h 1.05 KB