• Stephane Zermatten's avatar
    [Autofill Assistant] Fix to always use the page URL in controller. · a2ecca69
    Stephane Zermatten authored
    Before this patch, scripts were checked for the url from DidFinishLoad.
    This generally works, because most URLs loaded from a page belong to the
    same domain, but not all. In some cases, depending on loading order,
    this resulted in the set of runnable script being cleared unexpectedly.
    
    With this patch, the controller always uses the page URL. In most cases,
    since DidFinishLoad reports loading resources, this reports the same
    URL, wehich is a no-op for GetOrCheckScripts. The set of runnable
    scripts should now be stable on a given page.
    
    Bug: 806868
    Change-Id: Ifb8f5955c00396a9d2165eb0bacf73c8c825f76d
    Reviewed-on: https://chromium-review.googlesource.com/1257002Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#595855}
    a2ecca69
controller.cc 7.03 KB