• tzik's avatar
    Expand XRSessionCreationOptions on a WTF::Bind parameter · a2ef70e0
    tzik authored
    XRDevice passes an XRSessionCreationOptions instance to WTF::Bind, and
    its |output_context_| is a garbage collected object.
    As we have no chance to call XRSessionCreationOptions::Trace while it's
    held in the callback, |output_context_| may be collected incorrectly by
    GC.
    
    This CL expands XRSessionCreationOptions members to the parameters of
    XRDevice::OnRequestSessionReturned to fix the object graph.
    
    Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Iae4750dbec20d99f838f45d69fc3b782ed71cee2
    Reviewed-on: https://chromium-review.googlesource.com/1160741Reviewed-by: default avatarBrandon Jones <bajones@chromium.org>
    Reviewed-by: default avatarBill Orr <billorr@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#580392}
    a2ef70e0
xr_device.h 4.79 KB