GitLab

This reverts commit 94d22097.

Reason for revert: Tests on the pixel 2 GPU are now fixed.
See gpu-fyi-try-android-p-pixel-2-skv-32 trybot.

Changes:

1) We now call OnDisconnect if we were already connected when calling
   SetNewSocketForTesting() this fixes gpu-fyi-try-android-p-pixel-2-skv-32

2) GetDefaultTraceConfig() is now in a unnamed namespace in the .cc file rather
   then a member function. This was needed for ubsan_vptr as described in
   crbug/997318

Original change's description:
> Revert "Enable a new SYSTEM background tracing mode."
>
> This reverts commit 9c5df46a.
>
> Reason for revert: timing out tests
>
> Original change's description:
> > Enable a new SYSTEM background tracing mode.
> >
> > This mode will allow us to set up a background scenario and deliver
> > triggers to the system when something interesting is happening. Which
> > will allow us to only upload traces that are of interest.
> >
> > Bug: 979583
> > Change-Id: Ic48ea08e3f9fafccaf045847cc0ddfa76d11611c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760736
> > Commit-Queue: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: oysteine <oysteine@chromium.org>
> > Auto-Submit: Stephen Nusko <nuskos@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#689563}
>
> TBR=avi@chromium.org,oysteine@chromium.org,eseckler@chromium.org,nuskos@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 979583,997206
> Change-Id: I51889cecfdc1ac392fb199b1a190b14880801e6d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768981
> Reviewed-by: enne <enne@chromium.org>
> Commit-Queue: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#690047}

TBR=avi@chromium.org,enne@chromium.org,oysteine@chromium.org,eseckler@chromium.org,nuskos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 979583, 997206, 997318
Change-Id: Ib7052fbb7f2b67d85657494ab59d111a58213cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768768Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690883}