GitLab

This reverts commit dc64daa2.

Reason for revert: Consistent failures on ASan/LSan builds:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38493

==7494==ERROR: AddressSanitizer: container-overflow on address 0x60200014be98 at pc 0x55bf547a29f5 bp 0x7ffe684dac20 sp 0x7ffe684dac18
READ of size 8 at 0x60200014be98 thread T0
    #0 0x55bf547a29f4 in ash::WindowCycleList::ReplaceWindows(std::__1::vector<aura::Window*, std::__1::allocator<aura::Window*> > const&) ./../../ash/wm/window_cycle_list.cc:541
    #1 0x55bf547a29f4 in ?? ??:0
    #2 0x55bf5479fb9c in ash::WindowCycleController::MaybeResetCycleList() ./../../ash/wm/window_cycle_controller.cc:126
    #3 0x55bf5479fb9c in ?? ??:0
    #4 0x55bf5467e1a5 in ash::DesksController::ActivateDeskInternal(ash::Desk const*, bool) ./../../ash/wm/desks/desks_controller.cc:553
    #5 0x55bf5467e1a5 in ?? ??:0
    #6 0x55bf54688fb2 in ash::DeskActivationAnimation::PrepareDeskForScreenshot(int) ./../../ash/wm/desks/desk_animation_impl.cc:171
    #7 0x55bf54688fb2 in ?? ??:0
    #8 0x55bf54689402 in ash::DeskActivationAnimation::OnStartingDeskScreenshotTakenInternal(int) ./../../ash/wm/desks/desk_animation_impl.cc:128
    #9 0x55bf54689402 in ?? ??:0
    #10 0x55bf5468722c in ash::DeskAnimationBase::OnStartingDeskScreenshotTaken(int) ./../../ash/wm/desks/desk_animation_base.cc:96

Original change's description:
> cros: Window cycle list (alt-tab) resets if open during desk swap.
> 
> While the flag for limiting windows to the current active desk is
> enabled, if a user swaps desks while the window cycle list is open, the
> contents will not update to the new active desk.
> 
> This CL makes the window cycle list reset if it is open and a desk
> swap occurs while the aforementioned flag is enabled.
> 
> Test: LimitedWindowCycleControllerTest.CycleShowsActiveDeskWindows
> Bug: 1067327
> Change-Id: I9d940ad82a2f05ab1d2fd9e8c5115d5f3eda9826
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398559
> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806749}

TBR=xdai@chromium.org,chinsenj@chromium.org

Change-Id: I60f4c419f33a2c0f5d749b50cfb2eda2ee06cb44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1067327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410029Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806937}