• Soumadeep Mazumdar's avatar
    Fix pen/touch selection handles not disappearing on refresh · a35f58db
    Soumadeep Mazumdar authored
    Issue: Pen/Touch selection handles persist even on refresh. On refresh,
    the active client is invalidated before handles are dismissed.
    Selection handles in PDF created in touch selection controller currently
    had no way of being destroyed on a tab refresh before the actual parent
    was destroyed. This is not the case in HTML where there is an explicit
    call made to HideAndDisalllowShowingAutomatically to remove the handles
    from aura observer depending on window focus lost.
    
    Fix: Added call to Hide and not show handles automatically on
    destruction. Following similarly from HTML, this call is made from
    PDFWebContentsHelper destructor which takes care of removing the
    selection handles before destroying the controller. Since this is tied
    to the client, it does not remove existing handles in other active
    clients.
    
    Bug: 1110815
    
    Change-Id: I9818f06ac8fe7fac3223472a58088544f2bc462a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359652
    Commit-Queue: Soumadeep Mazumdar <somazu@microsoft.com>
    Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
    Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#809243}
    a35f58db
pdf_web_contents_helper.cc 9.34 KB