• Doug Arnett's avatar
    Reworks PreviewsDecider to defer ECT checks for Hint-based previews. · a3dc7158
    Doug Arnett authored
    This is meant to allow Slow Page Triggering of Previews - that is, for
    previews that may specify variable network quality thresholds based
    on the URL (via OptimizationHints), the ECT is deferred until commit
    time.
    
    It renames and refactors the ShouldAllow* and IsURLAllowed* methods
    to give them more power (it pushes down the ECT threshold determination
    instead of having multiple call sites try to provide). There is some
    reordering of the PreviewsAvailablity passed reasons.
    
    Some more cleanup is merited but deferred to keep the diffs simpler for
    this change.
    
    
    Bug: 895581
    Change-Id: Id8636312a9e707dd1181ca0df514f3f743347671
    Reviewed-on: https://chromium-review.googlesource.com/c/1310562
    Commit-Queue: Doug Arnett <dougarnett@chromium.org>
    Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
    Reviewed-by: default avatarRyan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606243}
    a3dc7158
previews_optimization_guide_unittest.cc 62.5 KB