• Nicholas Verne's avatar
    Reland "First browser tests for upgrader dialog" · a478dc51
    Nicholas Verne authored
    This reverts commit 31a96092.
    
    Reason for revert: Browser test failure only happens for
    is_chrome_branded build. Disabled that case only.
    
    Original change's description:
    > Revert "First browser tests for upgrader dialog"
    >
    > This reverts commit 54171d06.
    >
    > Reason for revert: crbug/1067636 CrostiniUpgraderDialogBrowserTest.ShowsOnAppLaunch failed on linux-chromeos-chrome
    >
    > Original change's description:
    > > First browser tests for upgrader dialog
    > >
    > > These tests cover the correct behavior on app launch.
    > >
    > > Bug: 1024693
    > > Change-Id: I9808e7492e696f8fea89bf5c7eba49439c9fc5aa
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135091
    > > Commit-Queue: Nicholas Verne <nverne@chromium.org>
    > > Reviewed-by: Nic Hollingum <hollingum@google.com>
    > > Cr-Commit-Position: refs/heads/master@{#756193}
    >
    > TBR=nverne@chromium.org,hollingum@google.com
    >
    > Change-Id: I520ae534296f744c59f29aca7cbdaada5dc94327
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1024693
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135871
    > Reviewed-by: Owen Min <zmin@chromium.org>
    > Commit-Queue: Owen Min <zmin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#756282}
    
    TBR=zmin@chromium.org,nverne@chromium.org,hollingum@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1024693
    Change-Id: I859ced5cc37e9f3248fb9fba4f793db917f8a5cc
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136981
    Commit-Queue: Nicholas Verne <nverne@chromium.org>
    Reviewed-by: default avatarNicholas Verne <nverne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#756606}
    a478dc51
BUILD.gn 355 KB