• James Cook's avatar
    lacros: Improve window parenting for select file dialogs · a4d4b817
    James Cook authored
    Select file dialogs are implemented in ash-chrome via
    SelectFileDialogExtension, which requires an aura::Window owning window
    for the dialog.
    
    Use the currently active (frontmost) window, which will usually be the
    spawning Lacros window. Verify that it's still a ShellSurface, just in
    case window activation has changed between when the user initiated the
    file picker and ash-chrome has received the mojo message.
    
    This isn't quite right -- in theory a non-active window could spawn a
    file picker -- but it's better than a modal file picker that blocks
    the whole desktop.
    
    Bug: 1090587
    Test: multiple lacros windows can have their own file picker children
    Change-Id: I582cd534e49228f3da5ab67e5ad99812f1a48432
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303681Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#789719}
    a4d4b817
DEPS 351 Bytes