• John Chen's avatar
    Revert "[ChromeDriver] Remove unused shadow DOM object cache" · a555a91b
    John Chen authored
    This reverts commit 4fe92e6c.
    
    Reason for revert: Causing failures in a couple of Java tests:
    ElementEqualityTest.testAnElementFoundInADifferentFrameViaJsShouldHaveSameId
    ElementFindingTest.testAnElementFoundInADifferentFrameViaJsCanBeUsed
    
    Original change's description:
    > [ChromeDriver] Remove unused shadow DOM object cache
    > 
    > ChromeDriver uses object caches for use while calling JavaScript
    > functions. The data structure was designed to allow a separate cache for
    > each shadow DOM, but that feature was never used, and objects in shadow
    > DOMs have always been stored in the main page cache. This CL removes
    > unused code, and resolves differences between test expectancies and
    > actual code behavior. It prepares for future changes to make the object
    > cache standard compliant.
    > 
    > Bug: chromedriver:1461
    > Change-Id: I10fcd94a7fd2359cc43fe6bc7241d36647e9d744
    > Reviewed-on: https://chromium-review.googlesource.com/c/1485011
    > Commit-Queue: John Chen <johnchen@chromium.org>
    > Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#635754}
    
    TBR=crouleau@chromium.org,johnchen@chromium.org
    
    Change-Id: I7e092258ef2298d2bccc27ef8bd4ffdea5e5eee2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromedriver:1461
    Reviewed-on: https://chromium-review.googlesource.com/c/1490747Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#635792}
    a555a91b
call_function_test.html 7.7 KB