• Taiju Tsuiki's avatar
    Revert "Introduce explicit state to keyboard_controller." · a55a1b5d
    Taiju Tsuiki authored
    This reverts commit 1fd2f73e.
    
    Reason for revert:
    This CL causes a compile failure.
    The failure log is:
    https://build.chromium.org/p/chromium/builders/Win/builds/56026
    
    c:\b\c\b\win_archive\src\ui\keyboard\keyboard_test_util.cc(54): warning C4373: '`anonymous-namespace'::ControllerStateChangeWaiter::OnStateChanged': virtual function overrides 'keyboard::KeyboardControllerObserver::OnStateChanged', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
    c:\b\c\b\win_archive\src\ui\keyboard\keyboard_controller_observer.h(34): note: see declaration of 'keyboard::KeyboardControllerObserver::OnStateChanged'
    
    Original change's description:
    > Introduce explicit state to keyboard_controller.
    > 
    > Bug: 719905
    > Change-Id: I14a1ee6b8e66c4f4c98ea4957dde7a7e0d75aad3
    > Reviewed-on: https://chromium-review.googlesource.com/516866
    > Commit-Queue: Keigo Oka <oka@chromium.org>
    > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#478568}
    
    TBR=oshima@chromium.org,bshe@chromium.org,oka@chromium.org,yhanada@chromium.org
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 719905
    
    Change-Id: I14143cde82fa85757be72ee9aed622577fd40dd7
    Reviewed-on: https://chromium-review.googlesource.com/530732Reviewed-by: default avatarTaiju Tsuiki <tzik@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#478572}
    a55a1b5d
keyboard_controller_browsertest.cc 9.2 KB