GitLab

RenderFrameHostImpl was recently modified to only update the value
GetIsolationInfoForSubresources() returns to only return the value of
the committed page. This matches the behavior of GetCommittedOrigin(),
and the old behavior of ComputeSiteForCookies (which was accidentally
changed a couple months back), so callers will get a consistent view of
the world.

This API is necessarily racy, since neither RenderFrameHostImpl nor the
caller generally know whether the call wants the old IsolationInfo
value, or the new one.

ContentAutofillDriver seems to be calling this method before a page
commits, while it's still pending. This CL switches it over to using
the pending IsolationInfo value, instead of the committed one, which
should match previous behavior. Once RenderDocument is implemented,
consumers will hopefully be bound to a document instead of a frame,
which will resolve the ambiguities/raciness with this API.

Fixed: 1157517
Change-Id: I938a23a08a96e4ad4e79798b9e930d2a321b9328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586237
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Auto-Submit: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836611}