GitLab

This is a reland of 62414cfc

Test improved to avoid flakes.

Original change's description:
> Avoid recycling sync tabs if commit pending
>
> When a tab is closed, it's possible that the corresponding history
> hasn't been committed yet, and hence there is a risk that synced history
> is lost if the entity is recycled (for another tab that is opened).
>
> In this patch, and behind a feature toggle, this issue is prevented by
> *not* freeing tab nodes while the sync entity is unsynced. Old tabs are
> excluded from this (to avoid problems with expired history) and a max
> cap is also introduced to the number of tabs in this state, in order to
> avoid memory regressions.
>
> Bug: 882489
> Change-Id: I6dd796642f9553f2713a0814731897a4ffb13f0b
> Reviewed-on: https://chromium-review.googlesource.com/c/1356541
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612971}

TBR=treib@chromium.org

Bug: 882489
Change-Id: Ib3f3ff9e4d620512435d9b22ba7b2c338f92203f
Reviewed-on: https://chromium-review.googlesource.com/c/1357086Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612980}