GitLab

This reverts commit 34d7e5df.

Reason for revert: Speculative fix in patchset 2

Original change's description:
> Revert "Mac: windows always display as key if a child is key"
>
> This reverts commit e8438fe0.
>
> Reason for revert: https://crbug.com/1050430
>
> Original change's description:
> > Mac: windows always display as key if a child is key
> >
> > On other platforms, user expectation is that a parent window will display
> > as inactive when a modal is showing. This isn't the case on Mac.
> >
> > Additionally, the code that passes key commands up to the parent window
> > uses this status to determine whether to pass keys from child windows up.
> >
> > This change (hopefully) shows a window as active iff a child is active.
> > It plays well with the current code that handles this for bubbles because
> > PaintAsActive is now reference counted.
> >
> > Still outstanding: making a non-key child window key *does* cause the
> > browser frame to be drawn as key and *does* handle hotkeys correctly,
> > but does *not* fix the traffic lights until the browser window has been
> > interacted with.
> >
> > Bug: 1046540
> > Change-Id: I1629e66457c42b268c2283a8dbeb6823c66b1111
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033432
> > Commit-Queue: Leonard Grey <lgrey@chromium.org>
> > Reviewed-by: ccameron <ccameron@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#739444}
>
> TBR=ccameron@chromium.org,lgrey@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1046540
> Change-Id: Ic25e1562df10809be9cdc9cd886fbf794b96b3c6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047085
> Reviewed-by: Leonard Grey <lgrey@chromium.org>
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739878}

TBR=ccameron@chromium.org,lgrey@chromium.org

Change-Id: I6ac87880427b118ab06b822f7372e3b345dab86e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048144Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740447}