-
chrome://media-appchrome://media-app-guestTrent Apted authored
Installs these routes as webui with basic structure and no permissions. Code added as a component in //chromeos/components/media_app_ui so that any chrome dependencies are clearly documented. --enable-features=MediaApp is required to enable the app at runtime on ChromeOS. The app is loaded as a guest (currently in an <iframe>) hosted in another chrome:// WebUI host that may be granted privileges in future. Currently the WebUI loaded in the <iframe> uses a chrome:// scheme, but this is not the long-term plan. A js2gtest is added with a test fixture that enables these flags and does integration testing. A build-time flag, enable_cros_media_app determines the bulk of what is served inside the sandboxed guest. When false, it provides a mock that facilitates integration testing even when is_chrome_branded is false. An internal change - https://crrev.com/i/1646974 - provides the content when is_chrome_branded is true (enable_cros_media_app must be set manually in args.gn until that lands). Bug: 996088 Change-Id: Ied7a41795409bdc8c028e63155f37452be84532e Test: MediaAppUIBrowserTest.WebviewHasAppElement Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767457 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697850}
a6deb201