• Matt Menke's avatar
    Fix incorrect DCHECK in SpdySessionPool's destructor. · a6f2e8fb
    Matt Menke authored
    The destructor was checking that |spdy_session_request_map_| is empty.
    This used to be true, as |spdy_session_request_map_| used to just
    contain SpdySessionRequests, which are cancelled on request destruction.
    However, it now also contains callbacks used to delay redundant H2
    connection requests, which have no cancellation semantecs, so there
    may be pending callbacks when the SpdySessionPool is destroyed.
    
    This CL fixes the DCHECK by just checking that there are no pending
    SpdySessionRequests.
    
    
    Bug: 966991
    Change-Id: I5f8e36d62850ffab83db38742250fae8b6eefff1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635437
    Commit-Queue: Ryan Hamilton <rch@chromium.org>
    Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#664518}
    a6f2e8fb
spdy_session_pool.cc 29.4 KB