• Aaron Colwell's avatar
    Pass real_url to CanBePlacedInDefaultSiteInstance() instead of url. · a795baf9
    Aaron Colwell authored
    All other calls to CanBePlacedInDefaultSiteInstance() provide the user
    URL, but the call in SiteInstanceImpl::GetSiteForURLInternal() passes
    the effective URL stored in |url| instead. This can lead to differing
    behavior than other call sites. This change makes all the call sites
    consistent. This causes subtle change in behavior on a platform that
    chooses to enable default SiteInstance and uses effective URLs
    (e.g. hosted apps). I do not believe Chrome currently has a platform
    that combines these features.
    
    Bug: 1085275
    Change-Id: I6ae445f2e45a31f91a4428a6c2fc0a340157b75f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186639Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
    Commit-Queue: Aaron Colwell <acolwell@chromium.org>
    Auto-Submit: Aaron Colwell <acolwell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#771098}
    a795baf9
site_instance_impl_unittest.cc 66 KB