• Hayato Ito's avatar
    Revert "Reland "VulkanImage: support create from GpuMemoryBufferHandle on Android"" · a7ff4aa1
    Hayato Ito authored
    This reverts commit 105f5197.
    
    Reason for revert: build failure
    
    https://ci.chromium.org/p/chromium/builders/ci/android-archive-dbg/4471
    
    Failure
    Step compile failed. Error logs are shown below:
    [86291/95274] SOLINK ./libvk_tests__library.cr.so
    FAILED: libvk_tests__library.cr.so libvk_tests__library.cr.so.TOC lib.unstripped/libvk_tests__library.cr.so
    /b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --reade...(too long)
    ld.lld: error: undefined symbol: gfx::GpuMemoryBufferHandle::GpuMemoryBufferHandle(base::android::ScopedHardwareBufferHandle)
    >>> referenced by vulkan_android_unittests.cc:133 (../../gpu/vulkan/android/vulkan_android_unittests.cc:133)
    >>>               obj/gpu/vulkan/android/vk_tests__library/vulkan_android_unittests.o:(gpu::VulkanImplementationAndroidTest_CreateVkImageFromAHB_Test::TestBody())
    
    
    Original change's description:
    > Reland "VulkanImage: support create from GpuMemoryBufferHandle on Android"
    > 
    > This is a reland of 838eb034
    > 
    > Original change's description:
    > > VulkanImage: support create from GpuMemoryBufferHandle on Android
    > >
    > > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace
    > > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace
    > > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well.
    > >
    > > Bug: None
    > > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587
    > > Commit-Queue: Peng Huang <penghuang@chromium.org>
    > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
    > > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#753394}
    > 
    > TBR=rjkroege@chromium.org,vasilyt@chromium.org
    > 
    > Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng
    > Bug: None
    > Change-Id: Ie6132474ef4a386ed661116aa8f580fd8460901d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121442
    > Reviewed-by: Peng Huang <penghuang@chromium.org>
    > Commit-Queue: Peng Huang <penghuang@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#753501}
    
    TBR=penghuang@chromium.org,rjkroege@chromium.org,vasilyt@chromium.org
    
    Change-Id: Ifbb45c4dbb1017d26d68c1216f3b5bdaece36991
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: None
    Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120995Reviewed-by: default avatarHayato Ito <hayato@chromium.org>
    Commit-Queue: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#753527}
    a7ff4aa1
vulkan_image.h 3.87 KB