• Dominik Röttsches's avatar
    Avoid triggering DWriteFontLookupTableBuilder callbacks in shutdown · a83d645e
    Dominik Röttsches authored
    Speculative fix for test flakiness in issues below.
    
    As per dcheng@'s recommendations in issue 1066456, remove
    CallbackWrappers:
    
    1) For DWriteFontProxyImpl::GetUniqueNameLookupTableIfAvailable we can
    immediately return by calling the callback explicitly.
    
    2) For DWriteFontProxyImpl::GetUniqueNameLookupTable the callback is
    enqueued in DWriteFontLookupTableBuilder in a
    base::DeferredSequencedTaskRunner and gets run from there or does not
    during shutdown - which is as expected. No need for an extra wrapper.
    
    Bug: 1066456
    Change-Id: I21891bd3cf5db7379b9e8d366cb405e7f43e8326
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164828
    Auto-Submit: Dominik Röttsches <drott@chromium.org>
    Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Dominik Röttsches <drott@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#762871}
    a83d645e
about_flags_browsertest.cc 13.9 KB