• David Bienvenu's avatar
    Update no-inlining for a clang-cl world · a86573a2
    David Bienvenu authored
    With VC++ marking a function as non-optimized with MSVC_DISABLE_OPTIMIZE would
    prevent it from being inlined, however with clang-cl that does not work,
    leading to confusing crash stacks.
    
    The fix is to use NOINLINE instead of MSVC_DISABLE_OPTIMIZE, which is
    more explicit and specific anyway.
    
    Bug: 873359
    Change-Id: I374c15af002c1864abac1d9a26f20026cc941a07
    Reviewed-on: https://chromium-review.googlesource.com/1179961Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#584531}
    a86573a2
logging_chrome.cc 15.8 KB